refactor: migrate make:command to AbstractGeneratorCommand - #10543
Open
paulbalandan wants to merge 1 commit into
Open
paulbalandan wants to merge 1 commit into
paulbalandan wants to merge 1 commit into
Conversation
paulbalandan
force-pushed
the
command-generator
branch
2 times, most recently
from
September 12, 2026 17:18
1c01884 to
8903b1d
Compare
michalsn
approved these changes
Sep 14, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
I think we should only support executing old commands. Generating them isn't something we should care about.
This comment has been minimized.
This comment has been minimized.
paulbalandan
force-pushed
the
command-generator
branch
from
September 15, 2026 08:27
8903b1d to
19cffcc
Compare
Member
Author
Updated. Removed the wording for support for generating legacy commands. |
paulbalandan
force-pushed
the
command-generator
branch
from
September 15, 2026 11:12
19cffcc to
70d7cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #10524 .
Behavior change: generated commands are now modern, both for basic and generator commands. I added a way to re-point to the old commands for those who want. But I don't think we need that. Let me know what you think.
Checklist: